search

grandma-collaboration / skyportal_grandma_dev

Little Git Repo to keep track of the work done by the A4 ESILV TEAM
2 stars 0 forks source link

Adrien/Adrien Sorting by date saved running out after switching few pages in the SOURCES page #15

Closed Adiman007 closed 1 year ago

Adiman007 commented 1 year ago

If you sort by most recent date saved on page 1 of the sources page, the sorting will be reset after reaching the 3rd page.

Theodlz commented 1 year ago

Hi @Adiman007, thanks for opening an issue, great reflex. This is a Skyportal issue right? Opening an issue here is great so we can follow your advancements regarding the tasks given to you by Sarah in a centralized manner. However, you also need to create an issue on SkyPortal main (not your fork, the proper SkyPortal). That way, the core team of SP (short for SkyPortal) knows about it and knows that someone is working on it.

Theodlz commented 1 year ago

Once any of you have started working on that, please move it to the 'In Progress' column of the project board.

Adiman007 commented 1 year ago

ok will do !

Adiman007 commented 1 year ago

hi @Theodlz , I have tried working again on it because we worked on the source page during the workshop with Adrien but I can't wrap my head around what's the origin of the problem. Because I have found a fix to the problem but I just don't know why it does fix the problem :sweat_smile:

Theodlz commented 1 year ago

Hi @Adiman007 A bug fix is still a bug fix hahaha. Open a PR and I'll have a look. As long as we understand why it fixes it its good enough. So lets investigate together

Adiman007 commented 1 year ago

ok, ok, I just removed a line in SourceTable.jsx and magically the sorting doesn't reset anymore, maybe you will be able to help me understand why, I open the PR asap.

Adiman007 commented 1 year ago

https://github.com/skyportal/skyportal/pull/3830 P.S : I fixed all the problems in my VScode where 10k files were showned as modified and more :smile: