graphman65 / linter-vhdl

Atom vhdl linter
https://atom.io/packages/linter-vhdl
MIT License
6 stars 2 forks source link

GHDL: Wrong command parameter sequence #5

Closed dommynik closed 6 years ago

dommynik commented 6 years ago

Hi, while trying out this linter extension for my VHDL2008 code, I found out, that the -- args: --std=08 parameter in the first line of the VHDL file did not work as expected. I tried to directly call GHDL with the following parameters: ghdl.exe -s vhdl2008-file.vhd --std=08, but this seems to ignore the last argument. I then tried the following parameters: ghdl.exe -s --std=08 peak_detector.vhd, and with this the VHDL2008 analysis has worked. I looked at the plugin implementation, and found that a small change in main.js solves the problem:

main.js:48: await exec("${compiler}" ${command} "${editorPath}" ${argsString}, options); to main.js:48: await exec("${compiler}" ${command} ${argsString} "${editorPath}", options);

Is there a reason, why argsString is appended at the end?

graphman65 commented 6 years ago

Hi, I fixed this. Let me know if it doesn't work :) Thanks