search

graphpaperpress / Sell-Media

a WordPress plugin that allows anyone to sell, license and protect images, videos, audio and other media files.
GNU General Public License v2.0
58 stars 48 forks source link

Rely on core archive/hover styling for all themes #613

Closed thadallender closed 9 years ago

thadallender commented 10 years ago

One of the biggest issues we've had is inconsistent/changing hover styles of Sell Media archives in Sell Media themes. Because we've integrated Lightbox into core (so we could do "Client Proofing" - a much needed feature that Sell Media didn't have and was a deal breaker for many people) I needed to change the core UI of Sell Media archives. This way we can show TITLE, ADD TO LIGHTBOX, BUY buttons on hover. In doing so, it's inevitably caused conflicts with Sell Media themes (which styled Sell Media archives differently).

I think Sell Media archives should be styled in core Sell Media, so there is a consistent UI experience in all themes.

Consequently, we'll need to update/change (mostly remove CSS) in all Sell Media themes that have styled archives. I did Stock Photography. Please get started on the rest. Here is what needs to be done:

  1. Remove lightbox page template, JS, CSS from Sell Media Themes
  2. Remove conflicting styles for Sell Media archives in Sell Media Themes.
  3. Make suggestions if needed to improve this.
maharzan commented 10 years ago

I think Sell Media archives should reflect how theme archives is designed for better/similar page experiences. For example in Lookbook, it shows arrays of thumbnails and if we have buy button outside of the image, the design doesn't look good. While it could be Sell Media design by default for other themes, we should be able to overwrite that in theme to make the experience smoother. Otherwise, it will look like the page is broken or something.

thadallender commented 10 years ago

I agree, but we'll now be packaging into core a default design that already looks like many of the themes. It won't be an "unstyled" layout. It was wrong for us to initially release Sell Media without any default archive styles, which is why themes started styling them. It will look like this and can be tweaked in themes as needed.

screenshot 2014-05-12 13 10 33

rickalday commented 10 years ago

May I add that we should probably allow templating for the search and search result pages.

thadallender commented 9 years ago

Version 2.0 brings all styling into core. Themes can still alter it if needed.