search

gridap / GridapSolvers.jl

Solvers and preconditioners for the Gridap ecosystem.
https://gridap.github.io/GridapSolvers.jl/
MIT License
10 stars 1 forks source link

Error in SchurComplementSolvers.jl #41

Open oriolcg opened 9 months ago

oriolcg commented 9 months ago

I think there is an error in this line: https://github.com/gridap/GridapSolvers.jl/blob/0e626022447647d476d7d3f2f44c7b6e09757136/src/LinearSolvers/SchurComplementSolvers.jl#L65

To my understanding it should be something like:

copy!(bp,y_p); mul!(bp,C,x_u,-1.0,1.0)  # bp  = y_p - C*(A^-1 y_u)

I was having wrong results in my application and this modification gives the good solution.

JordiManyer commented 9 months ago

Yes, that looks like a bug. I'll have a look. In any case that solver is due a rather big revision soon.