Calling residual! instead of jacobian!

gridap / GridapSolvers.jl

Solvers and preconditioners for the Gridap ecosystem.

https://gridap.github.io/GridapSolvers.jl/

MIT License

13 stars 1 forks source link

Calling residual! instead of jacobian! #54

Open oriolcg opened 6 months ago

oriolcg commented 6 months ago

Hi @JordiManyer, I was doing some code profiling (an issue to be reported/addressed in Gridap) and I found this possible error:

https://github.com/gridap/GridapSolvers.jl/blob/26aa6f995e156034de102f40e4c69be510399bb3/src/BlockSolvers/BlockFEOperators.jl#L64

I think here it should be calling jacobian! instead of residual!, right?

JordiManyer commented 6 months ago

Hi @oriolcg , The BlockFEOperators are halfway-implemented. I need to re-define the API and add functionalities that I want to have. I am currently tied into other things, I'll probably leave this for version 0.4.