search

gridap / Tutorials

Start solving PDEs in Julia with Gridap.jl
MIT License
124 stars 41 forks source link

Updating to PartitionedArrays v0.3 #170

Closed JordiManyer closed 1 year ago

JordiManyer commented 1 year ago

This PR fixes the distributed tutorials following the updates to PartitionedArrays.jl v0.3

JordiManyer commented 1 year ago

Hi @ericneiva @amartinhuertas ,

The latest changes that Eric introduced to CellQuadrature in PR 885 break the low-level tutorial (as you can see in the CI tests). This is due to CellQuadrature no longer implementing the CellDatum API correctly, mainly the DomainStyle method.

We can either change the tutorial (and illustrate the DomainStyle feature with another CellDatum structure) or add back the method for CellQuadrature.

How do you want to proceed?

ericneiva commented 1 year ago

Hi, @JordiManyer, thanks for reporting this.

I overlooked it completely because, as you can imagine, I didn't run the tutorials before merging that PR (sorry about that).

I removed the DomainStyle signature in PR 885, namely,

DomainStyle(::Type{CellQuadrature{DDS,IDS}}) where {DDS,IDS} = DDS()

because, as a CellQuadrature has two DomainStyle attributes (data and integration), I found it a little confusing.

However, if I look at the doc of DomainStyle(), the signature still makes sense because the arrays of CellQuadrature are always stored in the DomainStyle of the data.

We can either change the tutorial (and illustrate the DomainStyle feature with another CellDatum structure) or add back the method for CellQuadrature.

I'd do the latter :)

JordiManyer commented 1 year ago

Hi @ericneiva ,

Great! Once you have the PR in Gridap, @amartinhuertas can do the release. It might take a week since he is away atm. Once we have a new release I'll merge this PR.