search

gruhn / vue-qrcode-reader

A set of Vue.js components for detecting and decoding QR codes.
https://gruhn.github.io/vue-qrcode-reader
MIT License
2.03k stars 330 forks source link

overlay class possibly conflicting with app css style #208

Closed tewfik-dj closed 3 years ago

tewfik-dj commented 3 years ago

The default tracking seems to use an overlay class by default. If you happen to have the same class declared globally in your project, then there is the possibility of a conflict, and maybe unexpected behavior.

I suggest a short warning to be added to the readme.md file so that people won't run into this (like me). The ideal fix (imho) would be to rename such a generic class and use a prefix to ensure uniqueness. (e.g: qrcode-reader-*)

Thanks!

gruhn commented 3 years ago

Thanks for pointing this out. I blindly assumed the new CSS-in-JS approach would cause all class attributes to be replaced with inline style.

gruhn commented 3 years ago

fix is out: v2.3.14

tewfik-dj commented 3 years ago

fix is out: v2.3.14

Thanks for the quick fix! Appreciated.