gruhn / vue-qrcode-reader

A set of Vue.js components for detecting and decoding QR codes.
https://gruhn.github.io/vue-qrcode-reader
MIT License
2.1k stars 335 forks source link

Vue 3.2.22 crashes, 3.2.21 no error, how does the vue3 branch gets updated #281

Closed cimpok closed 1 year ago

cimpok commented 2 years ago

The very same code that was working with Vue 3.2.21 crashes after upgrading to Vue 3.2.22 with the following error

TypeError: Cannot read properties of null (reading 'isCE')_ at renderSlot (runtime-core.esm-bundler.js?816e:5827) at Proxy.render (VueQrcodeReader.common.js?8f1e:367) at renderComponentRoot (runtime-core.esm-bundler.js?21f2:464) at ReactiveEffect.componentUpdateFn [as fn] (runtime-core.esm-bundler.js?21f2:4231) at ReactiveEffect.run (reactivity.esm-bundler.js?6481:160) at setupRenderEffect (runtime-core.esm-bundler.js?21f2:4357) at mountComponent (runtime-core.esm-bundler.js?21f2:4140) at processComponent (runtime-core.esm-bundler.js?21f2:4098) at patch (runtime-core.esm-bundler.js?21f2:3693) at ReactiveEffect.componentUpdateFn [as fn] (runtime-core.esm-bundler.j

I don't want to be a nuisance with this (yes, I know the Vue3 branch is a preview, and I can also choose not to upgrade Vue yet), I'm just thinking maybe it is a good opportunity to zoom in and catch this bug (if it is really a bug in VueQrcodeReader) with such a minor change in Vue's core code causing it. Anyone else having this issue with the Vue3 branch?

Another bug. The above is on my Andriod phone, but on iPhone IOS 15.1 the component does not start with any vue versions. I see there is a bug fix in v3.0.4 release made in the master after the branching for vue3. This fix targets the issue I have on iPhone. I am confused, are those using the vue3 branch supposed to follow and make these fixes manually?

dioncodes commented 1 year ago

I'm having the exact same error. In a vue3 Ionic project it randomly stopped working. Downgrading vue doesn't solve this either, though... Did you find a solution for this?

gruhn commented 1 year ago

The package is now fully migrated to Vue 3, so try the newest release. Reopen if the issue persists.