fix: Turn off torch on exit - Githubissues

gruhn / vue-qrcode-reader

A set of Vue.js components for detecting and decoding QR codes.

https://gruhn.github.io/vue-qrcode-reader

MIT License

2.03k stars 330 forks source link

fix: Turn off torch on exit #383

Closed gruhn closed 8 months ago

gruhn commented 9 months ago

See: #380

netlify[bot] commented 9 months ago

Deploy Preview for vue-qrcode-reader ready!

Name	Link
Latest commit	faa773b944cf189c3fe523bfbd185acdd219d3e3
Latest deploy log	https://app.netlify.com/sites/vue-qrcode-reader/deploys/652295a5860a75000883880f
Deploy Preview	https://deploy-preview-383--vue-qrcode-reader.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebisbe commented 9 months ago

On my Xiaomi it's still not turning off the torch.

https://github.com/gruhn/vue-qrcode-reader/assets/6747962/5a2a246e-7ae3-4a8c-9af7-9e0241468d25

gruhn commented 8 months ago

@ebisbe @alexandrmucha can you check the deploy preview again?

alexandrmucha commented 8 months ago

Now it works perfectly, you can switch between cameras and the flash turns off correctly. Thanks!

gruhn commented 8 months ago

Credit goes to @Sec-ant :)

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 5.3.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: