search

grzegorz914 / homebridge-melcloud-control

Homebridge plugin for Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation, publish as dynamic external platform accessory.
MIT License
49 stars 2 forks source link

Fan speed increments are incorrect in my air conditioner model #6

Closed CyberMrProper closed 2 years ago

CyberMrProper commented 2 years ago

These are the params coming in the API:

"ModelSupportsFanSpeed": true, "HasAutomaticFanSpeed": true, "NumberOfFanSpeeds": 3,

and the current HK fan speed steps:

grzegorz914 commented 2 years ago

Are you sure 6 Is Auto, can you post the debug log if fan is in Auto mode?

grzegorz914 commented 2 years ago

Please try 0.2.9-beta and let me know

CyberMrProper commented 2 years ago

I will test it when I’m back home. No, I was mentioning 6 just to list all the steps in the slides (not the actual value for fan in auto). As of yesterday, when I set the fan at full speed, it set it to auto, so your logic is ok in that front. I think the only fix in here is the amount of fan speed the device supports .

grzegorz914 commented 2 years ago

Ok, then I think the auto from your unit will report 0

CyberMrProper commented 2 years ago

Yes, it's 0 for auto.

Speed 1 "FanSpeed": 1,

Speed 2 "FanSpeed": 2,

Speed 3 "FanSpeed": 3,

AUTO "FanSpeed": 0,

I tested your beta, and AUTO (maximum position in HK slider) doesn't seem to work (see error below). As per the speeds, the invalid slider speed options (4 and 5) are gone now and looks ok.

[7/4/2022, 6:51:17 PM] [melcloudcontrol] Air Conditioner: Aire, Set fan speed mode: AUTO [7/4/2022, 6:51:17 PM] [homebridge-melcloud-control] Error: at RotationSpeed.Characteristic.characteristicWarning (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2142:105) at RotationSpeed.Characteristic.validateUserInput (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2030:14) at RotationSpeed.Characteristic.updateValue (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1457:20) at HeaterCooler.Service.updateCharacteristic (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Service.ts:481:35) at MELCLOUDCLIENTDEVICE. (/usr/local/lib/node_modules/homebridge-melcloud-control/index.js:301:81) at MELCLOUDCLIENTDEVICE.emit (node:events:527:28) at MELCLOUDCLIENTDEVICE. (/usr/local/lib/node_modules/homebridge-melcloud-control/src/melcloudclientdevice.js:201:22) at MELCLOUDCLIENTDEVICE.emit (node:events:527:28) at MELCLOUDCLIENTDEVICE. (/usr/local/lib/node_modules/homebridge-melcloud-control/src/melcloudclientdevice.js:150:22) at MELCLOUDCLIENTDEVICE.emit (node:events:527:28)

grzegorz914 commented 2 years ago

Try beta.15 please

CyberMrProper commented 2 years ago

beta.15 works like a charm. Thanks!

grzegorz914 commented 2 years ago

Thanks for testing, 0.2.9 released