Don't use Kernel as a class name

gtamba / spice_rub

Ruby wrapper for the NASA-JPL CSPICE library via SciRuby

Other

9 stars 3 forks source link

Don't use Kernel as a class name #6

Closed translunar closed 8 years ago

translunar commented 8 years ago

I strongly advise against using Kernel as a class name, since it's already used by Ruby core. Call it SpiceKernel instead.

gtamba commented 8 years ago

I thought it'd be okay to hide it as a private constant which only KernelPool interacts with but it seems nothing is truly invisible in Ruby. I'll change it to SpiceKernel

gtamba commented 8 years ago

Fixed as of commit https://github.com/gau27/spice_rub/commit/6c851defaa8c17b5ef000eb5fb954ab2945eed56 (Forgot to tag it in the commit message)