search

gtreshchev / RuntimeAudioImporter

Runtime Audio Importer plugin for Unreal Engine. Importing audio of various formats at runtime.
MIT License
336 stars 69 forks source link

Added direct transcode for RAW audio #69

Closed lkoren21 closed 2 months ago

lkoren21 commented 3 months ago

When using transcode with an intermediate format some quality was lost. Now all transcoding is done from format to format without the need for an intermediate format.

gtreshchev commented 3 months ago

That's a great approach, thank you for your contribution! The only thing is that having separate declarations and definitions of templated functions may lead to code generation and linker issues on some compilers, so it would be better to implement this function in a header file for the best cross-platform results. Can you please move the full definition of TranscodeTo to the RuntimeAudioTranscoder.h file and include #include "Codecs/RAW_RuntimeCodec.h" at the top of the file?

lkoren21 commented 3 months ago

Thank you. I'll do it ASAP.

lkoren21 commented 3 months ago

I've made the necessary changes. You can merge if everything is all right.