search

gu-fan / clickable.vim

Make things clickable
39 stars 2 forks source link

Conflicts with salt-vim plugin #4

Open rominf opened 9 years ago

rominf commented 9 years ago

Steps to reproduce:

  1. Install https://github.com/saltstack/salt-vim
  2. Open salt state file: vim /tmp/s.sls
  3. Start typing: salt://ssssssssssssssssssssss...
  4. See how vim eats all CPU after some "s".

Salt-vim plugin works fine without clickable plugin, I think the problem is in latter plugin.

gu-fan commented 9 years ago

the http and file matching pattern used by clickable.vim now are too long (though I optimzed them several times). Maybe I should let them not matching in all files.

rominf commented 9 years ago

@Rykka I don't think that the problem is in your regex, because if I try to type the same address in the plain text file, it works fine.

gu-fan commented 9 years ago

ok, I will check it.

davidjb commented 9 years ago

Ouch, I hit this one too. I'm not sure what changed in my environment to bring this about, but trying to edit an existing .sls file of any size causes vim to use 100% cpu (eg hang) until killed. Disabling clickable is definitely a solution for now.

gu-fan commented 9 years ago

clickable has hacked syntax and seems the syntax highlighting of url/file matching is overkilling the memory...

I have not got a better solution for this currently.