search

guilhermesad / rspotify

A ruby wrapper for the Spotify Web API
MIT License
717 stars 290 forks source link

Ensure consistent use of Addressable::URI.encode #238

Closed cobyism closed 3 years ago

cobyism commented 3 years ago

I was running into the issue described in this stackoverflow thread, which was basically that when using more recent versions of ruby all API calls with rspotify would just throw undefined method 'encode' for URI:Module.

As per the insightful suggestion by @kstrukov in the stackoverflow thread, I tried simply updating rspotify to be consistent in its use of Addressable::URI.encode instead of the deprecated URI::encode, and it seems to have solved the issue for me so figured I'd propose the change.

flanger001 commented 3 years ago

I was about to do the same thing here, so good on you for grabbing this one! @guilhermesad can you merge this and cut a new version?