search

guilhermesad / rspotify

A ruby wrapper for the Spotify Web API
MIT License
713 stars 286 forks source link

Ruby 3.0+ Support #252

Closed aquaflamingo closed 2 years ago

aquaflamingo commented 2 years ago

Howdy!

First off, awesome library! Been building a few projects with it, thanks for building this :)

It seems that RSpotify breaks with the move to Ruby 3, specifically it seems centered around the URI.encode method from the looks of this issue: https://github.com/guilhermesad/rspotify/issues/236

Seems that the method has now been removed in higher version of Ruby, namely 3.0.

I see a few pull requests open that could help out https://github.com/guilhermesad/rspotify/pull/228 https://github.com/guilhermesad/rspotify/pull/233

Wondering if it would be possible to get them merged. Happy to help out where possible to get these over the line if interested. Let me know, thanks again for the lib! :)

aquaflamingo commented 2 years ago

Whoops, disregard. Seems that the addressable gem has already been bumped to 2.8.0 in https://github.com/guilhermesad/rspotify/commit/94d0cc3f543166cb12c9b5504bb559e7e2937af9.

So perhaps those PRs will not help.

aquaflamingo commented 2 years ago

Ah sincere apologies - this was total user error on my part. Closing !