guillermo-navas-palencia / optbinning

Optimal binning: monotonic binning with constraints. Support batch & stream optimal binning. Scorecard modelling and counterfactual explanations.
http://gnpalencia.org/optbinning/
Apache License 2.0
449 stars 99 forks source link

Error while importing optbinning installed from scorecard branch #29

Closed GabrielSGoncalves closed 4 years ago

GabrielSGoncalves commented 4 years ago

Hi Guillermo,

I getting this error when I try to import optbinning that was installed from the scorecard branch:

import optbinning
ImportError                               Traceback (most recent call last)
<ipython-input-2-3b16b6a50809> in <module>
     47 
     48 from decouple import config
---> 49 from optbinning import OptimalBinning
     50 
     51 # Definir variáveis de ambiente

~/miniconda3/envs/jeitto/lib/python3.7/site-packages/optbinning-0.5.0-py3.7.egg/optbinning/__init__.py in <module>
----> 1 from .binning.binning import OptimalBinning
      2 from .binning.continuous_binning import ContinuousOptimalBinning
      3 from .binning.multiclass_binning import MulticlassOptimalBinning
      4 from .binning.binning_process import BinningProcess
      5 from .binning.mdlp import MDLP

~/miniconda3/envs/jeitto/lib/python3.7/site-packages/optbinning-0.5.0-py3.7.egg/optbinning/binning/binning.py in <module>
     15 
     16 from ..logging import Logger
---> 17 from ..preprocessing import preprocessing_user_splits_categorical
     18 from ..preprocessing import split_data
     19 from .auto_monotonic import auto_monotonic

~/miniconda3/envs/jeitto/lib/python3.7/site-packages/optbinning-0.5.0-py3.7.egg/optbinning/preprocessing.py in <module>
     15 from sklearn.utils import check_consistent_length
     16 from sklearn.utils import compute_class_weight
---> 17 from sklearn.utils.validation import _check_sample_weight
     18 
     19 from .outlier import ModifiedZScoreDetector

ImportError: cannot import name '_check_sample_weight' from 'sklearn.utils.validation' (/home/gabriel/miniconda3/envs/jeitto/lib/python3.7/site-packages/sklearn/utils/validation.py)

When I install optbinning from master branch it runs ok. Do you know what might be causing this?

Att

Gabriel

guillermo-navas-palencia commented 4 years ago

Hi Gabriel,

I do not have this issue, I am using sklearn version 0.22: https://github.com/scikit-learn/scikit-learn/blob/95d4f0841d57e8b5f6b2a570312e9d832e69debc/sklearn/utils/validation.py. This branch is work in progress but depending on your sklearn version, it might require an update in requirements.txt.

GabrielSGoncalves commented 4 years ago

Hi Guillermo, I updated the sklearn version to 0.22 and the error didn't show up again. I was using the 0.21 version. Thanks for the help!