search

gurkenlabs / litiengine

LITIENGINE 🕹 The pure 2D java game engine.
https://litiengine.com/
MIT License
731 stars 94 forks source link

Project source layout #423

Closed weisJ closed 2 years ago

weisJ commented 2 years ago

This PR aligns project layout for (re)sources to the conventional gradle layout. The current layout of core and utiliti isn't inherently wrong, but shared already uses the conventional layout. Either way we should align the layout for each sub-project.

weisJ commented 2 years ago

Very strange. Checking out a clean version of this branch the tests run fine for me locally. Any idea why the CI is failing?

steffen-wilke commented 2 years ago

@weisJ @nightm4re94 did this PR wipe the entire Git history for every single file? or was it #421 ?

however we achieve it, we need to preserve/restore the history somehow.

weisJ commented 2 years ago

That was #421. But as mentioned before git history isn’t lost for those files. The GitHub interface simply isn’t capable of showing changes for moved files. git log --follow will happily show the complete history

steffen-wilke commented 2 years ago

Okay, now @weisJ took over the repository 😄

Jokes aside: Just checked the IDE integration and it seems like Git Blame annotations still work - at least in IntelliJ (which is one of the key parts to me). Even though it's not as comfortable as before it's still workable I guess so we need to remember the --follow param every time we check the history when blaming/annotating manually.

Thanks for the clarification, hope GitHub gets this done soon.