Make litiengine modular - Githubissues

gurkenlabs / litiengine

LITIENGINE 🕹 The pure 2D java game engine.

https://litiengine.com/

MIT License

725 stars 93 forks source link

Make litiengine modular #437

Open weisJ opened 2 years ago

weisJ commented 2 years ago

It would be nice to have litiengine be a modular jar:

It allows consumers of the library to bundle their game using jpackage
Currently the utiLITI executable created by jpackage isn't fully self contained (as it's not a modular jar) i.e. on windows the /app directory is also necessary as it contains all dependencies. For fully modular projects it's possible to package all dependencies in the resulting jar making it portable.

As the engine is already build using a newer java version (>= Java 9) being compliant with the module system shouldn't be a big problem ... except:

jinput isn't modular (this isn't a big problem as it can be used as an automatic module without much headache)
Most of the soudlib.* dependencies behave have split packages (i.e. multiple jars contain the same packages or even the same classes). This is really unfortunate as it is a hard blocker for going modular. A possible workaround would be to fork the repository and modify the build process to produce compatible jars.

Any thoughts on this?

Gamebuster19901 commented 2 years ago

Just thinking... if litiengine was modular, I think we could have (an updated version of) https://github.com/gurkenlabs/litiengine/pull/326 as an optional modular component, probably under a different repository though.

What do you guys think?