Typo fixes - Githubissues

gurkenlabs / litiengine

LITIENGINE 🕹 The pure 2D java game engine.

https://litiengine.com/

MIT License

725 stars 93 forks source link

Typo fixes #450

Closed mathieu-fanduel closed 1 year ago

nightm4re94 commented 2 years ago

Hi, just checking in if this PR is still in draft state or ready for review? cheers!

mathieu-fanduel commented 2 years ago

Actually it could be reviewed , these are some hopefully minimal changes ( fixing typo ) to get my teeth in the code base and review process

nightm4re94 commented 2 years ago

Hi, sorry this is taking longer than usual. We're on a sort of break from LITIENGINE due to heavy workload currently. What I can say however is that we would prefer PullRequests that are separated into different topics, for example:

one for fixing typos
one for proposing Entity opacity
one for Java 17 refactorings This speeds up reviews and lets us merge parts even if other parts need revisions.

mathieu-fanduel commented 2 years ago

Cool I will do that

nightm4re94 commented 2 years ago

Hi there, just checking in whether you're still interested in splitting this PR up into three separate ones. That would facilitate the review greatly.

nightm4re94 commented 1 year ago

Closing this due to inactivity. Thank you and feel free to resume at a later point :)