search

gurkenlabs / litiengine

LITIENGINE 🕹 The pure 2D java game engine.
https://litiengine.com/
MIT License
718 stars 94 forks source link

Fix name field in Sprite import panel #778

Closed nightm4re94 closed 3 months ago

nightm4re94 commented 1 year ago

The name panel in the Sprite import panel doesn't show the current spritesheet name or set it when changed.

iamllcoolray commented 9 months ago

Hey,

I am interested in resolving this issue. Would y'all be able to provide additional information and/or anything else that could help me?

iamllcoolray commented 9 months ago

Hi again,

I just wanted to comment again about my interest in tackling this issue. Can y'all provide additional information and/or anything else that could help me? For example, how I can replicate the bug, what the proper functionality should look like, where in the utiLITI project should start looking in...etc.

I know how busy everyone is so please get back to me when it is most convenient for y'all.

nightm4re94 commented 9 months ago

Hi, I'm sorry I was not yet able to respond. Having a busy week at work and some fun private events this week. I can't promise to be able to provide further details this week unfortunately.

nightm4re94 commented 8 months ago

Thanks for your patience. The problem lies in the SpritesheetImportPanel:

https://github.com/gurkenlabs/litiengine/assets/26114385/79fdbf83-9be3-4ff9-89c9-735315fdc8f2

There is a JTextField that is supposed to show the name of the selected spritesheet. It is also supposed to let you change the spritesheet name with your input. Neither of these behaviours work.

We might even consider dropping the JTextField entirely and letting users change the cell values in the sprite name list on the left.

iamllcoolray commented 8 months ago

Awesome! I'm going to look into this bug sometime next week. (My schedule just got busy)

nightm4re94 commented 8 months ago

I suppose it's not going anywhere until then - no hurry here 🙂

iamllcoolray commented 6 months ago

Thank you for being patient with me. I just finished my courses for this Fall semester and have more free time now. (It was brutal 😂)

So, I was trying to build Gradle in IntelliJ and got this error:

Build file 'C:\litiengine\build.gradle' line: 1

An exception occurred applying plugin request [id: 'de.gurkenlabs.semverguru', version: '1.3']
    > Failed to apply plugin 'de.gurkenlabs.semverguru'.
        > No match found

What do you think I should do to fix this?

nightm4re94 commented 6 months ago

I believe this is #796 again. Have you made sure to compile with Java 21?

iamllcoolray commented 4 months ago

So I found a solution for the bug.

https://github.com/gurkenlabs/litiengine/assets/20143111/7998b084-388e-4567-88df-f45a2143ba80

I got the Sprite name in the text field which updates the Sprite's name in the application.

iamllcoolray commented 3 months ago

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

Gamebuster19901 commented 3 months ago

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text

Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged.

You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged.

In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

iamllcoolray commented 3 months ago

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text

Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged.

You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged.

In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

Thank you so much. I just added Resolves #778 to the pull request.

Gamebuster19901 commented 3 months ago

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged. You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged. In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

Thank you so much. I just added Resolves #778 to the pull request.

It won't work now because it's already been merged.