Closed Mshnik closed 1 month ago
Amazing, your first Pull Request in the LITIENGINE repository! You have earned the rank of "contributor" - let us know your nickname in the Forum and on Discord so we can reward you with the new role :).
Oh nice! I would like the nickname Shnik
, please 👍
Looks good to me.
TextRenderer#renderWithLinebreaks throws a NullPointerException when invoked with a multiline string:
I tracked this down to a typo on line 334:
>= text.length()
should be>= s.length()
, ass
is the string for the current line andtext
is the whole multiline string.This pull request:
The unit test checks that no exception is thrown and that something is rendered, but I was unable to fully assert that the correct Glyphs are drawn due to Oracle locking down the
sun.font
module.