search

h2020-westlife-eu / wp6-repository

https://h2020-westlife-eu.github.io/wp6-repository/
MIT License
0 stars 0 forks source link

backend code review FileUploadController #18

Open TomasKulhanek opened 6 years ago

TomasKulhanek commented 6 years ago

The class org.cirmmp.spring.controller.FileUploadController is good to post binary files via HTTP - however, I'd be afraid, if it scales for big files. Therefore I'd recommend to remove this controller completely. The functionality to handle single files is already on WEBDAV interface which is provided by the apache mod_dav module, it can handle GET,POST,PUT,DELETE as well as PROPFIND (aka directory listing) on files on the server.

andreagia commented 6 years ago

We can remove FileUploadController and for me is ok to use webdav on apache controller to manage files on the server. How do you manage the files (on the server ) -> FileList class identity ?

TomasKulhanek commented 6 years ago

No FileList class - files belongs to dataset managed by backend api.

TomasKulhanek commented 6 years ago

Can you do that?