hMatoba / piexifjs

Read and modify exif in client-side or server-side JavaScript.
MIT License
571 stars 118 forks source link

getting RuntimeError: saveJpeg is not defined on CanvasSample.html #36

Closed aaronkyle closed 6 years ago

aaronkyle commented 6 years ago

Hi Matoba-san and thank you for this wonderful tool! I am new to JavaScript and trying to learn. I hope to use your tool to better ensure digital privacy for photos I put online.

I first tried getting your CanvasSample working by publishing the file through my gh-pages account and referencing the raw version of your piexif.js file. This didn't seem to be working as expected. I then tried porting your work into a JavaScript notebook called Observablehq, which revealed a RuntimeError: saveJpeg is not defined.

Since I used npm for the port (piexifjs@1.0.4), I wonder -- did something change in your piexif.js file so that you no longer use saveJpeg? Could that be the reason why the example doesn't work for me?

Thanks again for your time and for this tool!

aaronkyle commented 6 years ago

This comment can be closed. Although I am still having trouble getting the sample to work, I realized the error had to do with how I separated cells in the notebook