haganbt / pepp

PYLON Exporter ++
MIT License
5 stars 5 forks source link

output directory naming #100

Open erwanlenagard opened 8 years ago

erwanlenagard commented 8 years ago

Hi Ben,

I would like to submit a little optimisation. Currently you save data in pepp/output and you name subdirectories in the following format : config_filename+date

However, I use the same config file for several recordings. So, I've something like : pepp/output/myextract_2016-09-06-16.07.59 ==> recording 1 pepp/output/myextract_2016-09-06-16.08.59 ==> recording 2 pepp/output/myextract_2016-09-06-16.09.59 ==> recording 3 pepp/output/myextract_2016-09-06-17.07.59 ==> recording 1

It's not easy to archive data and find which directories contains data related to a specific recording

Would it be possible to name the output directories with the subscription_id ? or create a subdirectory with the subscription_id ?

I mean something like pepp/output/recording_1/myextract_2016-09-06-16.07.59 pepp/output/recording_1/myextract_2016-09-06-17.07.59 pepp/output/recording_2/myextract_2016-09-06-16.08.59 pepp/output/recording_3/myextract_2016-09-06-16.09.59 etc..

Thanks a lot ! :)

haganbt commented 8 years ago

@erwanlenagard - a nice option could be to set an environment variable when the script is called and use that as a subdirectory. Something like:

CUSTOM_DIR=foobar node app.js

You could then call that with whatever key you require e.g. recording_id. Would that meet your requirements?

erwanlenagard commented 8 years ago

It could be a good solution, especially because it gives you flexibility to name the subdirectory.

However, I feel more convenient to set the naming of the subdirectory to avoid "human errors". Your solution means you need to set the variable each time you run the script => you can load data to a wrong directory.