hal / testsuite.next

Testsuite for HAL
Apache License 2.0
2 stars 26 forks source link

Docker file of halconsole/hal-wildfly-nightly doesn't seems to be published on github #115

Closed marekkopecky closed 5 years ago

marekkopecky commented 5 years ago

Docker file of halconsole/hal-wildfly-nightly doesn't seems to be published on github

https://hub.docker.com/r/halconsole/hal-wildfly-nightly/tags/

cc @spriadka @honza-kasik

spriadka commented 5 years ago

The Dockerfile is present in the console repository (https://github.com/hal/console/tree/develop/docker)

marekkopecky commented 5 years ago

@spriadka This doesn't seems to be correct. According to the readme, halconsole/hal-wildfly-nightly is based on jboss/wildfly. This corresponds with comparison of docker inspect halconsole/hal-wildfly-nightly and docker inspect jboss/wildfly.

Dockerfile from console repository is based on jboss/base-jdk:11, not on jboss/wildfly ...

honza-kasik commented 5 years ago

@marekkopecky So this is the history:

@hpehl Why was the code removed?

hpehl commented 5 years ago

@honza-kasik @marekkopecky @spriadka Sorry for the broken build and missing docker images. The images have been removed by accident. I'm about to restore them. I'll comment here if everything is up and running again.

hpehl commented 5 years ago

I've restored the missing maven-docker setup https://github.com/hal/console/commit/607053f4395bb1f3d26ba758f9b566bd6527ef5e and pushed the docker images: https://cloud.docker.com/repository/list?namespace=halconsole.

marekkopecky commented 5 years ago

@hpehl Thank you. I'm comparing hal-wildfly and wildfly. Wildfly contains link to github sources in Source Repository section. Hal-wildfly not. Can you consider to add Source Repository section also to Hal-wildfly docker page?

hpehl commented 5 years ago

I've added the source repo for halconsole/hal, halconsole/hal-wildfly and halconsole/hal-wildfly-nightly.

However I did not setup automated builds since they require a maven run which is not possible in Docker Hub.

marekkopecky commented 5 years ago

@hpehl Thank you. In my PoV, this issue is solved now, so I close it now ...