Closed hpehl closed 4 years ago
According to the requirements in the analysis document, I think the tests should also cover the /subsystem=messaging-activemq/connection-factory=*
and /subsystem=messaging-activemq/pooled-connection-factory=*
configuration
These tests are almost identical to /subsystem=messaging-activemq/server=*/connection-factory=*
and /subsystem=messaging-activemq/server=*/pooled-connection-factory=*
.
Code freeze is is just around the corner and I'm actually already on PTO. Can we please merge anyway?
According to the analysis document the use-topology-for-load-balancing
attribute is present in following resources:
/subsystem=messaging-activemq/connection-factory=*
/subsystem=messaging-activemq/pooled-connection-factory=*
/subsystem=messaging-activemq/server=*/connection-factory=*
/subsystem=messaging-activemq/server=*/pooled-connection-factory=*
The document's test plan is:
Add tests which will navigate to the messaging configuration applications and make sure the attribute for the resources above is exposed.
Add tests to modify the attribute and make sure the modifications are stored in the management model.
Since the document's test plan is being applied to all of the exposed resources, not some of the resources I don't think this MR can be merged without 100% coverage of the requirements.
Additional tests are hard to implement and need a bigger refactoring. Manual testing showed no errors. That's why I decided to merge this anyway.
https://issues.jboss.org/browse/HAL-1603