search

hal / testsuite.next

Testsuite for HAL
Apache License 2.0
2 stars 26 forks source link

Element names changed #144

Closed vobratil closed 3 years ago

vobratil commented 3 years ago

Some tests crash because of incorrect names of expected elements. So far, this MR isn't fixing the issue with missing "hal-root-container", which causes the majority of test failures right now.

dcihak commented 3 years ago

@hpehl Could you please have a look at this, or reassign it to someone? Thanks.

hpehl commented 3 years ago

@dcihak Could you give some context please? Which tests fail? How do you run the test suite?

In the meantime I'll try to reproduce the error on my machine.

hpehl commented 3 years ago

@dcihak I can confirm that there are issues due to a refactoring in HAL. In particular all CSS selectors which are based on [data-element] don't work atm.

I'm about to fix the selectors and update the test suite.

vobratil commented 3 years ago

@hpehl Hi! You've already said it, pretty much. Tests that rely on the the "data-element" tag fail. I only took a look at the ones that were failing in our testsuite runs. This is how I run them: mvn test -Pbasic,firefox,domain,restoreConfig -Darq.extension.webdriver.firefox_binary="/opt/firefox/60.0.1/firefox/firefox" -Dwebdriver.gecko.driver="/opt/gecko/geckodriver-v0.20.1-linux64" -Dtest="${TEST}"

hpehl commented 3 years ago

Closing this with the upgrade to HAL 3.3.0.Final which replaces the [data-element] selectors with IDs & special classes.