hal / testsuite.next

Testsuite for HAL
Apache License 2.0
2 stars 26 forks source link

Fix for distributableweb, ee, remoting, hal-configuration and microprofiles tests. #152

Closed jedla97 closed 2 years ago

jedla97 commented 2 years ago

This MR include fixes for distributableweb, ee, remoting, hal-configuration and microprofiles tests modules and adding profile for EAP XP which is now mandatory for EAP. Each of the module fix is in its own commit.

In distributableweb module the css selector was edited to choose specify element. The bug was due to choosing wrong (first) element. (commit affd233)

In ee module the type setter was removed because it set wrong type in slotModule. (commit 63f2541)

In remoting module to create the connector the valid undertow service is needed. This fix create and remove valid socket and httpListener. (commit a183197)

In hal-configuration module the EMPTY_SUBSYSTEMS was updated. Some delay time for page to load up in setUp() method. And for pin and unpin the selector of element was changed to ensure the correct subsystem element is selected. (commit 2a58e79)

For microprofiles module the maven profile was added for successful test when microprofiles aren't available. The microprofile-health-api was bumped to 2.0 due to @Health annotation isn't supported. With this change the deployed package was changed by adding @Liveness annotation. For successful deploy it's necessary to reload server which was added. In metric tests was needed to expose all subsystem and after all test the exposing of subsystem is set back to false. In the microprofiles is not fully fixed due to bug which randomly occur. (commit 9a45e22 and 190172c)

The test run for modules is available here: https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-hal-3-basic-modularized-standalone/76/ Microprofiles failing but in console output is possible to see zero test run.

For microprofiles the succesful output here:

[INFO] Results:
[INFO] 
[WARNING] Tests run: 13, Failures: 0, Errors: 0, Skipped: 2
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] hal-testsuite 0.0.1-SNAPSHOT ....................... SUCCESS [  2.598 s]
[INFO] hal-testsuite-common ............................... SUCCESS [  6.889 s]
[INFO] resources-subsystem-fixtures ....................... SUCCESS [  3.585 s]
[INFO] tooling-deployment ................................. SUCCESS [  3.469 s]
[INFO] tests-configuration-microprofile 0.0.1-SNAPSHOT .... SUCCESS [01:18 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
jedla97 commented 2 years ago

Hi, @honza-kasik I fixed the reminders which you have or left comment there. Tested new changes where all results for fixed tests was successful [1].

[1] https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-hal-3-basic-modularized-standalone/81/

jedla97 commented 2 years ago

Hi @honza-kasik ! Here are the changes you requested.
I added fix for microprofiles for the bug which randomly occurred. The cause of this bug was that the info is saved to hashmap and the selector find 2 occurrences of same value. So it's needed to choose only first element.

As we discus on chat I change the xp profile to microprofile profile. Regarding this microprofile module was deleted from basic test and added to microprofile profile. That mean when somebody run the test with standalone profile the the microprofile test will not run.

The successful test are here: https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-hal-3-basic-modularized-standalone/

jedla97 commented 2 years ago

Hi @honza-kasik , I look what caused this instabilities and the result was that health tests not causing it. This instability happening somewhere in microprofile tests. In this case when I run the test 2nd time the server isn't restarted so without restart the error happen. When I fixing some of the test I remember that after some tests the server need restart. Due to this I change the position of reloadIfReguired to restart the server in BeforeClass method. With this we can ensure that after running all the test the microprofile module don't fail.

honza-kasik commented 2 years ago

Thank you @jedla97 ! LGTM! Merging!