search

hal / testsuite.next

Testsuite for HAL
Apache License 2.0
2 stars 26 forks source link

exclude commons-io from org.jboss.arquillian.graphene from dependencies #188

Closed dcihak closed 7 months ago

dcihak commented 1 year ago

Using wrong commons-io library version causes compilation error

[ERROR] /home/hudson/hudson_workspace/workspace/eap-74x-webconsole-basic-prepare/webconsole-testsuite/tests/keycloak/src/test/java/org/jboss/hal/testsuite/test/keycloak/KeycloakOperations.java:[158,36] no suitable method found for toString(java.io.InputStream,java.nio.charset.Charset) 11:55:46 [ERROR] method org.apache.commons.io.IOUtils.toString(java.io.InputStream,java.lang.String) is not applicable 11:55:46 [ERROR] (argument mismatch; java.nio.charset.Charset cannot be converted to java.lang.String) 11:55:46 [ERROR] method org.apache.commons.io.IOUtils.toString(byte[],java.lang.String) is not applicable 11:55:46 [ERROR] (argument mismatch; java.io.InputStream cannot be converted to byte[])

Test run: https://cp-jenkins.eapqe.psi.redhat.com/job/eap-74x-webconsole-basic-prepare/80/

jbliznak commented 1 year ago

is this resolving the same problem as https://github.com/hal/testsuite.next/pull/187 ?

dcihak commented 1 year ago

Not really sure, it would be worthy to try the fix as I don't know the consequences of the mentioned failure. The commons-io got there by the arquillian-browser-screenshooter as seen from the dependency tree:

[INFO] +- org.jboss.arquillian.graphene:arquillian-browser-screenshooter:jar:2.3.2:compile [INFO] | +- org.arquillian.extension:arquillian-recorder-screenshooter-impl-base:jar:1.1.0.Final:compile [INFO] | | +- org.arquillian.extension:arquillian-recorder-screenshooter-api:jar:1.1.0.Final:compile [INFO] | | | +- org.arquillian.extension:arquillian-recorder-api:jar:1.1.0.Final:compile [INFO] | | | +- org.arquillian.extension:arquillian-recorder-reporter-api:jar:1.1.0.Final:compile [INFO] | | | | - org.eclipse.persistence:org.eclipse.persistence.moxy:jar:2.5.1:compile [INFO] | | | | +- org.eclipse.persistence:org.eclipse.persistence.core:jar:2.5.1:compile [INFO] | | | | | - org.eclipse.persistence:org.eclipse.persistence.asm:jar:2.5.1:compile [INFO] | | | | - org.eclipse.persistence:org.eclipse.persistence.antlr:jar:2.5.1:compile [INFO] | | | - com.jhlabs:filters:jar:2.0.235:compile [INFO] | | +- org.arquillian.extension:arquillian-recorder-reporter-impl:jar:1.1.0.Final:compile [INFO] | | | +- org.arquillian.extension:arquillian-recorder-reporter-spi:jar:1.1.0.Final:compile [INFO] | | | - org.arquillian.extension:arquillian-recorder-video-api:jar:1.1.0.Final:compile [INFO] | | - org.apache.commons:commons-io:jar:1.3.2:compile

jbliznak commented 1 year ago

OK, confirmed it is the very same problem, we are now discussing the proper solution and then you should be able to cherrypick the same to 7.4.x branch.

dcihak commented 1 year ago

This should be solving the same issue, but in a more complex way https://github.com/hal/testsuite.next/pull/187.

dcihak commented 7 months ago

Closing, https://github.com/hal/testsuite.next/pull/205 opened instead.