search

hal / testsuite.next

Testsuite for HAL
Apache License 2.0
2 stars 26 forks source link

Logging subsystem refactoring + AbstractJASPIConfigurationTest checkstyle fixes #89

Closed spriadka closed 5 years ago

spriadka commented 5 years ago

@claudio4j this PR fixes checkstyle errors, which were present on the master branch, in the AbstractJASPIConfigurationTest, I also refactored LoggingFixtures to organize nested resources into the nested classes to create sort of namespace style for constants. I think this namespace style could be used for ElytronFixtures as well, WDYT?

claudio4j commented 5 years ago

I think this namespace style could be used for ElytronFixtures as well, WDYT?

I don't think is necessary to wrap each elytron resource address method in a dedicated class with only the method address, unfortunately the number of resources in elytron subsystem is big.

spriadka commented 5 years ago

Thanks, @claudio4j! Merging