Fixes various small things

halftheopposite / TOSIOS

The Open-Source IO Shooter is an open-source multiplayer game in the browser

MIT License

375 stars 78 forks source link

Fixes various small things #18

Closed LukeWood closed 4 years ago

LukeWood commented 4 years ago

Updates typescript compiler to use paths to handle package linking (better for live reload)
Updates the Application in GameManager to use the window's devicePixelRatio to prevent gaps between sprites (this is a problem when creating a map with 32x32 pixels)

LukeWood commented 4 years ago

amended commit to also:

Adds AutoDensity so rendering works the same with the native devicePixelRatio
Fixes circle clamping - you could clip out of the left end of the map and couldn't reach the far right.

halftheopposite commented 4 years ago

@LukeWood Thank you for your PR, I've been quite busy lately and sadly didn't get the chance to work on the project as I had expected, but I'll test and merge it this weekend if everything is good 👍. There is something I need to check on yarn workspaces first and packages linking.

LukeWood commented 4 years ago

sounds good! Don't sweat it no rush.

I am not using your deployment stuff actually so I very well may have broken that without realizing.

Thanks again for publishing tosios - it really helped me kick start my game :).

LukeWood commented 4 years ago

p.s. - linked you in my credits :). https://tp-scramble.io/credits. t

halftheopposite commented 4 years ago

@LukeWood Thanks for quoting me in your credits! Concerning your changes, I have actually refactored the whole configuration for workspaces, TypeScript and eslint. So now the paths and reload work especially well! Thanks for your first insights which gave me motivation to do this refactor (along other things). It will be shipped in 0.12.0