search

halkyonio / container-images

Repo containing info needed to build different images: supervisord, spring boot s2i, spring boot maven s2i, ...
1 stars 2 forks source link

fix: make hal-mvn-jdk image usable by other runtimes #3

Closed metacosm closed 5 years ago

metacosm commented 5 years ago

This accomplished via 2 means: first, make the image bundling some SB dependencies depend on this one instead of the reverse and second, parameterize the build command so that it retrieves a JARPATTERN env var to identify which jar needs to be run.

geoand commented 5 years ago

Is there supposed to be some documentation about JARPATTERN?

metacosm commented 5 years ago

LGTM.

Remark: It could be interesting that we decorate the image with some labels as quarkus did - https://github.com/quarkusio/quarkus-images/blob/master/quarkus-maven-overrides.yaml#L6-L14

Sure, this PR only focuses on getting things working for other runtimes.

metacosm commented 5 years ago

Is there supposed to be some documentation about JARPATTERN?

Just added some.

geoand commented 5 years ago

Is there supposed to be some documentation about JARPATTERN?

Just added some.

Thanks

metacosm commented 5 years ago

@jponge @Ladicek any comments on this?

jponge commented 5 years ago

LGTM