search

haltu / muuri

Infinite responsive, sortable, filterable and draggable layouts
https://muuri.dev
MIT License
10.8k stars 643 forks source link

bug in ItemDrag code #467

Closed kkoo95 closed 3 years ago

kkoo95 commented 3 years ago

I think there is a bug in ItemDrag here: https://github.com/haltu/muuri/blame/master/src/Item/ItemDrag.js#L469

it tries:

  if (this._isStarted) {
    ...
    var element = item._element;

but item does not seems to exists. it should be this._item

niklasramo commented 3 years ago

Thanks, well spotted, that is indeed a bug! And I'm wondering how this has not been spotted earlier 🤔 I'll patch it up asap.

niklasramo commented 3 years ago

Or do you want to patch it @kkoo95 ?

niklasramo commented 3 years ago

Okay, just patched this: https://github.com/haltu/muuri/releases/tag/0.9.4