search

hammy275 / mc-vr-api

An API to allow mod developers to see VR player data from Vivecraft.
GNU Lesser General Public License v3.0
8 stars 0 forks source link

Crash on Hotswitch #40

Closed hammy275 closed 8 months ago

hammy275 commented 11 months ago

https://discord.com/channels/178567952780623872/543161829325799426/1165681295687430274

https://discord.com/channels/178567952780623872/194213677560365056/1177725041237037137

hammy275 commented 8 months ago

Looked at this a bit longer, this is actually an issue in ImmersiveMC. Need to check that a player is in VR before attempting to render Item Immersives.

hammy275 commented 8 months ago

Re-opening, as this is actually a bug in MC VR API.

Although the above reasoning still applies and should make its way into ImmersiveMC, the traceback shows MC VR API throwing a NPE, when in actuality, it should be returning null. We likely need to try all of our VR data grabbing, then catch NPEs and return null from them.

hammy275 commented 8 months ago

Should hopefully be fixed. 1.19.x commit that fixes this is https://github.com/hammy275/mc-vr-api/commit/66dc7440a109d36aa999390f06c357abc3c7399b