search

hannesm / jackline

minimalistic secure XMPP client in OCaml
BSD 2-Clause "Simplified" License
250 stars 20 forks source link

no echo after quitting jackline in macOS #188

Closed Iix closed 5 years ago

Iix commented 6 years ago

In relation to bug #186 after quitting jackline in macOS terminal, there is no echo on key entries until the terminal is reset.

hannesm commented 6 years ago

maybe related to https://github.com/pqwy/notty/issues/22 which includes a workaround

hannesm commented 6 years ago

does opam pin add jackline https://github.com/hannesm/jackline.git#reset-tc work more nicely with your terminal? this branch saves the terminal state and restores before exiting.

hannesm commented 6 years ago

the mentioned branch isn't worth it... but I've seen/heard about this very same issue on other platforms as well (using xterm and UNIX)... worth investigating further (but I can't reproduce yet)

cfcs commented 5 years ago

I posted a fix to the notty issue referenced by @hannesm above.

cfcs commented 5 years ago

Fixed in https://github.com/hannesm/jackline/commit/e9cc0a3cdd44f96065c91f5db826c9a504d11082#diff-1f947de1e211dae385d88d792a4fd397R29 here.

hannesm commented 5 years ago

fixed in notty 0.2.2