hannesm / jackline

minimalistic secure XMPP client in OCaml
BSD 2-Clause "Simplified" License
251 stars 20 forks source link

Export notification state to file for use with systray #38

Closed cfcs closed 9 years ago

cfcs commented 9 years ago

Generates some warning messages because of the Lwt.bind-freakshow going on in the file writing function. I've still no idea how Lwt is supposed to be used, but this works for my purposes. Rewrites welcome :-)

hannesm commented 9 years ago

while I appreciate this contribution, I'm a bit uneasy with its current implementation (using Lwt.join and spreading all over). Instead, I'd do the following (and will if time permits):

This would cleanup the mutable notifications, and move the file writing into a single place.

hannesm commented 9 years ago

closing now that #55 (or #56) hit master. thanks!

cfcs commented 9 years ago

Awesome!