active contact is now sometimes gone

hannesm / jackline

minimalistic secure XMPP client in OCaml

BSD 2-Clause "Simplified" License

250 stars 20 forks source link

active contact is now sometimes gone #74

Closed hannesm closed 9 years ago

hannesm commented 9 years ago

this is some regression:

[x] if contact a@b/1 is active (unexpanded), and a@b/2 gets online (with higher priority)
[x] if contact a@b/1 and a@b/2 are online, /1 is active (unexpanded) and gets offline
[x] if contact a@b/1 is active, goes offline, and a@b/2 comes online
[x] if self contact comes online another time (again, priorities etc)
[x] if ctrl-q pressed, which jumps to an unexpanded contact

might be more cases as well... expand before focus/unfocus (or again: focus bare jid into unexpanded contact -- but i believe this gets worse)

hannesm commented 9 years ago

I like to preserve several invariants:

there's always a single active contact visible, which is in reverse color mode in the buddy list
the program itself does not change the active contact on its own (ok to do for broken xmpp clients with random resources)
the program itself does not modify the expand/collapsed state of contacts

the third invariant is already sometimes violated (if contact a@b/1 and a@b/2 are online, and 1 goes offline, it is collapsed). the other two are imho more important than the third (esp the second, since otherwise you might send messages to a resource with an encryption state which you did not intent to do).

thus: I'll expand at my own will within jackline. if someone can think of a better solution, please tell.

hannesm commented 9 years ago

this is all still (as of deed63f401a6c332b42f1e04f9f10ddcc3143518) horribly broken:

if multiple sessions are online, the contact is always expanded
offline messages from some (offline) jid won't highlight a single full contact (but rather stupidly blink around), offline jid is similar to online one...

all crap, needs more thinking and proper code

hannesm commented 9 years ago

focus on bare contact, then F5, focus on offline full contact -> nothing highlighted; also, single full contact shown should always contain all the history (e.g. if other sessions are offline and thus not displayed)

some more thinking needs to be done:

when/what to notify (subscription: bare, message: full)
when to expand (if notification of something not shown is there; corner case: similar session)
which history to show

hannesm commented 9 years ago

i again claim this is fixed now. let's see how long until i reopen this issue again...