hannesm / jackline

minimalistic secure XMPP client in OCaml
BSD 2-Clause "Simplified" License
248 stars 20 forks source link

Socks5 proxy support #90

Open cfcs opened 8 years ago

cfcs commented 8 years ago

Someone mentioned they'd want this feature for when using Tor. I'll try to add it when I get some time.

hannesm commented 8 years ago

socks4a should be all we need, shouldn't it? (much simpler than user + auth overhead of socks5)

hannesm commented 8 years ago

also someone reported torify (or torsocks and tor-resolv) work fine with jackline (but I agree that a socks implementation would be great!)

sternenseemann commented 8 years ago

Socks5 is more comonly used, isn't it?

cfcs commented 8 years ago

Socks4a will likely be fine for most user, however SOCKSv5 can be used by Tor to isolate circuits belonging to different contexts. I feel that is a nice enough feature that it would make sense to allow either a random username/password or a user-specified set to separate the traffic of two instances of Jackline going through the same Tor client. See the IsolateSOCKSAuth argument to the SOCKSPort setting.

hannesm commented 8 years ago

sounds good to me. I'd suggest to start with a socks library (at least client side); and afterwards finding an interface which unifies lwt sockets and socks, maybe (parts of) conduit come in handy..

cfcs commented 8 years ago

Yes, let's keep this open until someone gets around to doing it :)