hapifhir / hapi-fhir

🔥 HAPI FHIR - Java API for HL7 FHIR Clients and Servers
http://hapifhir.io
Apache License 2.0
2.04k stars 1.33k forks source link

HAPI 4.1.0 contains FHIR 4.0.0 structure defs in hapi-fhir-validation-resources-r4 #1591

Open lawley opened 4 years ago

lawley commented 4 years ago

NOTE: Before filing a ticket, please see the following URL: https://github.com/jamesagnew/hapi-fhir/wiki/Getting-Help

Describe the bug HAPI 4.1.0 contains old FHIR 4.0.0 structure defs in the hapi-fhir-validation-resources-r4 module.

To Reproduce Examine org/hl7/fhir/r4/model/profile/profiles-resources.xml

Expected behavior Should contain FHIR 4.0.1 structure defs

Environment (please complete the following information):

Additional context Add any other context about the problem here.

lawley commented 4 years ago

I believe this is the root cause of us seeing validation failures with respect to:

ref-1: SHALL have a contained resource if a local reference is provided ( (url: 1; ids: )) [reference.startsWith('#').not() or (reference.substring(1).trace('url') in %resource.contained.id.trace('ids'))]

which is the old constraint, while the new constraint is:

ref-1: SHALL have a contained resource if a local reference is provided ( (url: 1; ids: )) [reference.startsWith('#').not() or (reference.substring(1).trace('url') in %rootResource.contained.id.trace('ids'))]