ifMatch request param for PATCH request inside a Bundle transaction fails with HAPI-0518 error.

aditya-07 commented 2 years ago

NOTE: Before filing a ticket, please see the following URL: https://github.com/hapifhir/hapi-fhir/wiki/Getting-Help

Describe the bug Including ifMatch with etag value for a PATCH request inside a Bundle transaction causes the transaction to fail. PUT on the other hand works fine.

FYI: Non Bundle Http Patch request against the Patient works fine though.

Failing PATCH request

{
    "resourceType": "Bundle",
    "type": "transaction",
    "entry": [{
        "fullUrl": "Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4",
        "resource": {
            "resourceType": "Binary",
            "contentType": "application/json-patch+json",
            "data": "W3sib3AiOiJyZXBsYWNlIiwicGF0aCI6IlwvdGVsZWNvbVwvMFwvdmFsdWUiLCJ2YWx1ZSI6IjQwMTEyMzQ1NiJ9XQ=="
        },
        "request": {
            "method": "PATCH",
            "url": "Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4",
            "ifMatch": "W/\"11\""
        }
    }]
}

Response

{
    "resourceType": "OperationOutcome",
    "text": {
        "status": "generated",
        "div": "<div xmlns=\"http://www.w3.org/1999/xhtml\"><h1>Operation Outcome</h1><table border=\"0\"><tr><td style=\"font-weight: bold;\">ERROR</td><td>[]</td><td><pre>HAPI-0518: Invalid match URL[Patient?W/&quot;11&quot;] - URL has no search parameters</pre></td>\n\t\t\t</tr>\n\t\t</table>\n\t</div>"
    },
    "issue": [
        {
            "severity": "error",
            "code": "processing",
            "diagnostics": "HAPI-0518: Invalid match URL[Patient?W/\"11\"] - URL has no search parameters"
        }
    ]
}

Working PUT Request

{"resourceType":"Bundle","type":"transaction","entry":[{"fullUrl":"Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4","resource":{
    "resourceType": "Patient",
    "id": "e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4",
    "active": true,
    "name": [
        {
            "family": "Adams",
            "given": [
                "Adam"
            ]
        }
    ],
    "telecom": [
        {
            "system": "phone",
            "value": "401123456-01"
        }
    ],
    "gender": "male",
    "birthDate": "2020-02-14",
    "address": [
        {
            "city": "NAIROBI",
            "country": "Kenya"
        }
    ]
},"request":{"method":"PUT","url":"Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4","ifMatch":"W/\"11\""}}]}

Response

{
    "resourceType": "Bundle",
    "id": "be5b83f0-a3d3-440e-a542-8b9e54e166a6",
    "type": "transaction-response",
    "link": [
        {
            "relation": "self",
            "url": "http://hapi.fhir.org/baseR4"
        }
    ],
    "entry": [
        {
            "response": {
                "status": "200 OK",
                "location": "Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4/_history/12",
                "etag": "12",
                "lastModified": "2022-04-29T18:39:04.724+00:00"
            }
        }
    ]
}

To Reproduce Steps to reproduce the behavior:

Use the requests shown above to do a POST request to the https://hapi.fhir.org/baseR4/ and see the response.

Expected behavior Transaction should be successful of if ifMatch has the latest value or fail gracefully for the right reason if the etag provided is not the latest one on the server just like the PUT operation . e.g. Like the PUT response above.

{
"entry": [
        {
            "response": {
                "status": "200 OK",
                "location": "Patient/e642ec07-c4d1-4f3f-bae6-4cd9e7f9d0d4/_history/12",
                "etag": "12",
                "lastModified": "2022-04-29T18:39:04.724+00:00"
            }
        }
    ]
}

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information): http://hapi.fhir.org/baseR4 HAPI FHIR Test/Demo Server R4 Endpoint HAPI FHIR Server 6.0.0-PRE8-SNAPSHOT/3f58e277e6/2022-03-23

Browser Chrome & Postman tool

Additional context Add any other context about the problem here.

aditya-07 commented 2 years ago

@jingtang10

jmorenomarti commented 1 year ago

I have exactly the same problem. Any update on this? Thank you!

jingtang10 commented 1 year ago

Seems like this is to do with the etag being escaped?

aditya-07 commented 1 year ago

@tadgh This seems to work fine now on the latest hapi server. Could you please confirm that it has been fixed and maybe the version where it got fixed?

I tried updating a Patient and it seems to work fine.

POST https://hapi.fhir.org/baseR4/
Content-Type: application/fhir+json; charset=utf-8
Content-Length: 404

{
    "resourceType": "Bundle",
    "type": "transaction",
    "entry": [
        {
            "fullUrl": "Patient/11370346",
            "resource": {
                "resourceType": "Binary",
                "contentType": "application/json-patch+json",
                "data": "W3sib3AiOiJhZGQiLCJwYXRoIjoiXC9hY3RpdmUiLCJ2YWx1ZSI6dHJ1ZX0seyJvcCI6InJlcGxhY2UiLCJwYXRoIjoiXC90ZWxlY29tXC8wXC92YWx1ZSIsInZhbHVlIjoiMTIzNDU2Nzg5MSJ9XQ=="
            },
            "request": {
                "method": "PATCH",
                "url": "Patient/11370346",
                "ifMatch": "W/\"3\""
            }
        }
    ]
}
--> END POST (404-byte body)

200 OK https://hapi.fhir.org/baseR4/ (357ms)
  Server: nginx/1.18.0 (Ubuntu)
  Date: Wed, 01 Nov 2023 09:16:58 GMT
  Content-Type: application/fhir+json;charset=utf-8
  Transfer-Encoding: chunked
  Connection: keep-alive
  X-Powered-By: HAPI FHIR 6.9.5-SNAPSHOT/7e3c42549d/2023-09-09 REST Server (FHIR Server; FHIR 4.0.1/R4)
  X-Request-ID: rsa60y5IdEEyqQPS
  Content-Location: https://hapi.fhir.org/baseR4/Bundle/5543c581-7333-42b2-97e7-b5ef79c05349
  Location: https://hapi.fhir.org/baseR4/Bundle/5543c581-7333-42b2-97e7-b5ef79c05349
{
    "resourceType": "Bundle",
    "id": "5543c581-7333-42b2-97e7-b5ef79c05349",
    "type": "transaction-response",
    "link": [
        {
            "relation": "self",
            "url": "https://hapi.fhir.org/baseR4"
        }
    ],
    "entry": [
        {
            "response": {
                "status": "200 OK",
                "location": "Patient/11370346/_history/4",
                "etag": "4",
                "lastModified": "2023-10-20T07:14:14.707+00:00",
                "outcome": {
                    "resourceType": "OperationOutcome",
                    "text": {
                        "status": "generated",
                        "div": "<div xmlns=\"http://www.w3.org/1999/xhtml\"><h1>Operation Outcome</h1><table border=\"0\"><tr><td style=\"font-weight: bold;\">INFORMATION</td><td>[]</td><td>Successfully patched resource &quot;Patient/11370346/_history/4&quot;.</td></tr></table></div>"
                    },
                    "issue": [
                        {
                            "severity": "information",
                            "code": "informational",
                            "details": {
                                "coding": [
                                    {
                                        "system": "https://hapifhir.io/fhir/CodeSystem/hapi-fhir-storage-response-code",
                                        "code": "SUCCESSFUL_PATCH",
                                        "display": "Patch succeeded."
                                    }
                                ]
                            },
                            "diagnostics": "Successfully patched resource \"Patient/11370346/_history/4\"."
                        }
                    ]
                }
            }
        }
    ]
}
<-- END HTTP (1253-byte body)

jingtang10 commented 3 months ago

as per aditya's last comment this should have been closed? @tadgh can you pls confirm?