hapifhir / hapi-fhir

🔥 HAPI FHIR - Java API for HL7 FHIR Clients and Servers
http://hapifhir.io
Apache License 2.0
2.04k stars 1.33k forks source link

Use of slf4j 2.x is an issue for the hapi-fhir-jpaserver-starter project #5186

Open jkiddo opened 1 year ago

jkiddo commented 1 year ago

https://github.com/hapifhir/hapi-fhir/blob/de9a74766652b57a0e3c8c077d74543988ba205c/hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/coordinator/ReductionStepDataSink.java#L103

-that line causes runtime issues on the https://github.com/hapifhir/hapi-fhir-jpaserver-starter as it uses slf4j 1.7.x -> https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/8ef50832d3459d4eb35ecb4f116c580475acb59d/pom.xml#L26

tadgh commented 1 year ago

Heya, is it just the atTrace API that causes this problem? If so, we can swap that out for now.

jkiddo commented 1 year ago

Yep

tadgh commented 1 year ago

Can jpaserver-starter not upgrade versions of SLF4J? Or is there some spring dependency pinning it?

jkiddo commented 1 year ago

With spring boot 2.7 (which is what is used right now, the dependencies looks like this: https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-dependencies/2.7.14 )

jkiddo commented 1 year ago

and HAPI FHIR itself actually declares dependency to Spring Boot at https://github.com/hapifhir/hapi-fhir/blob/de9a74766652b57a0e3c8c077d74543988ba205c/pom.xml#L975

jkiddo commented 1 year ago

and this part could confuse some ... https://github.com/hapifhir/hapi-fhir/blob/de9a74766652b57a0e3c8c077d74543988ba205c/pom.xml#L984 I guess