Open codeforgreen opened 2 weeks ago
Formatting check succeeded!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.43%. Comparing base (
497b9f2
) to head (125c04f
). Report is 120 commits behind head on master.:exclamation: Current head 125c04f differs from pull request most recent head 650f35c
Please upload reports for the commit 650f35c to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
6008
What was done:
IJobPartitionProvider
which can return a list of partitions for operation requests. The implementation will handle requests configured withRequestPartitionId.allPartitions
and return a list of all partitions, including the default partition. Please mind that this interface is likely to change as another factor for determining partitions to run a job against can also be a list of urls provided as parameters in these jobs. Further simplification can be made and I plan to add another PR just for that refactoring simplification (bringUrlPartitioner
into the mix as it also computes partitions for jobs).ReindexProvider
to use the new bean to compute the partitionsIModelJson
) were merged and made some of the templating across job steps simpler. I removed the "partitioned" prefix out of the classes since there was no use-case not requiring partitions and it seemed right. For example,RequestDetails
did not get extended when partitioning was added.GenerateRangeChunksStep
andJobPartitions
. Also made updates such that the chunk partitionId is the authoritative source for partition information to handle the next steps for the chunk.GenerateRangeChunksStep
such that can have cartesian product (urls x partitions) for generating chunks provided in the job parameters.