haroohie-club / SerialLoops

An editor for Suzumiya Haruhi no Chokuretsu (The Series of Haruhi Suzumiya)
https://haroohie.club/chokuretsu/serial-loops
GNU General Public License v3.0
14 stars 6 forks source link

Fixup ASM hack application crash #343

Closed jonko0493 closed 7 months ago

jonko0493 commented 7 months ago

In order to localize more efficiently, the LoopyProgressTracker attempts to localize all its strings. This is normally fine, but during ASM hack application, we pass all strings that come back from make/docker which can result in null strings being passed. This caused a crash that was caught by our UI tests.