Closed rebeccacremona closed 3 years ago
Answer: no, the Docker call does -not- work in Circle, as is. Hmmmmmmm.
Merging #61 (c835d42) into new-architecture (35a671d) will increase coverage by
8.52%
. The diff coverage is91.98%
.
@@ Coverage Diff @@
## new-architecture #61 +/- ##
====================================================
+ Coverage 82.45% 90.98% +8.52%
====================================================
Files 27 29 +2
Lines 1237 1375 +138
====================================================
+ Hits 1020 1251 +231
+ Misses 217 124 -93
Impacted Files | Coverage Δ | |
---|---|---|
web/main/admin.py | 68.50% <ø> (ø) |
|
web/main/urls.py | 100.00% <ø> (ø) |
|
web/main/models.py | 93.72% <69.23%> (+5.24%) |
:arrow_up: |
web/main/views.py | 94.30% <71.42%> (-1.07%) |
:arrow_down: |
web/main/tasks.py | 95.42% <93.63%> (+64.89%) |
:arrow_up: |
web/conftest.py | 84.36% <100.00%> (+3.52%) |
:arrow_up: |
web/main/apps.py | 100.00% <100.00%> (ø) |
|
web/main/serializers.py | 100.00% <100.00%> (ø) |
|
web/main/signals.py | 100.00% <100.00%> (ø) |
|
web/main/test/test_queue.py | 100.00% <100.00%> (ø) |
|
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 35a671d...c835d42. Read the comment docs.
I can't wait to see how this works in CI: will the Docker calls work?