search

harvard-lil / perma-capture

GNU Affero General Public License v3.0
3 stars 6 forks source link

Use correct setting #66

Closed rebeccacremona closed 3 years ago

rebeccacremona commented 3 years ago

This change was hotfixed on the staging server.

rebeccacremona commented 3 years ago

Oh, right, now I get the problem..... on the staging server, where the main app is NOT in a Docker container, the job needs to make f'{settings.BROWSERTRIX_HOST_DATA_DIR}/{outputdir_uuid}'. But in dev/circle, the job is running in a container, and the job needs to make the directory using a local path, the path as it looks inside the container, not the path as is looks on the host.

This whole thing is pretty inelegant: I'm rethinking. But, will make contingent on the DOCKERIZED setting for now.

bensteinberg commented 3 years ago

Do we want to run the main app in a Docker container in production?

rebeccacremona commented 3 years ago

Do we want to run the main app in a Docker container in production?

I don't think so: if we do, we have to give that container access to the host Docker daemon like this https://github.com/harvard-lil/perma-capture/blob/new-architecture/docker-compose.yml#L45, so that it can launch containers. I think that's creepy.

I should be able to clean this up. (And, this might be another reason to use a volume instead of bind mount.)