hashgraph / hedera-smart-contracts

Contains Hedera Smart Contract Service supporting files
Apache License 2.0
45 stars 54 forks source link

HIP-1010: Updating token custom fees through hts-precompile #607

Closed mamorales1 closed 1 month ago

mamorales1 commented 11 months ago

Problem

Currently, HederaTokenService contract doesn't allow users to update token custom fees so if you have created a token with a fee schedule key but you didn't create the token with a custom fee, you will not be able to add custom fees to your token, since updateTokeInfo function updates HederaToken struct where custom fees are not present. To do so, you only have the choice of using HTS's TokenFeeScheduleUpdateTransaction transaction, but you will not be able to do it through smart contracts.

Solution

Creating new functions only to update token custom fees.

Alternatives

### Tasks
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/855
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/874
- [ ] https://github.com/hashgraph/hedera-services/issues/11508
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/876
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/862
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/910
- [ ] https://github.com/hashgraph/hedera-smart-contracts/issues/915
Nana-EC commented 9 months ago

Hi @mamorales1 thanks for the ticket. Indeed it does seem to be a gap, we'll take a look and circle back here.

ebadiere commented 8 months ago

We've confirmed that this is an issue. We are working on a solution and will let you know when it's on the road map.

lukelee-sl commented 8 months ago

Tracking issue in the the services repo - https://github.com/hashgraph/hedera-services/issues/11508