hashgraph / hedera-smart-contracts

Contains Hedera Smart Contract Service supporting files
Apache License 2.0
37 stars 51 forks source link

feat: implement ihrc in hts system contract mocks (#478) #640

Closed mshakeg closed 5 months ago

mshakeg commented 6 months ago

Description:

This PR extends the IHRC interface solidity version support. Additionally, the HTS System Contract mock now implements the IHRC interface.

Related issue(s):

Fixes #598 and task 5 in #478

Notes for reviewer:

I'm not sure whether IHRC(htsAddress).isAssociated(evmAddress) has yet been implemented, but I've added it here regardless.

Checklist

mshakeg commented 6 months ago

Hey @Nana-EC any idea why the PR Title Check still fails?

Nana-EC commented 6 months ago

Hey @Nana-EC any idea why the PR Title Check still fails?

Not sure. Can look into it but it's something we can workaround if it's the only issue.

I left other blocking comments

mshakeg commented 5 months ago

Hey @Nana-EC can we get this merged? don't want to have to resolve any potential conflicts.