hashgraph / hedera-smart-contracts

Contains Hedera Smart Contract Service supporting files
Apache License 2.0
38 stars 53 forks source link

chore: cleaned up Solidity warnings #701

Closed quiet-node closed 6 months ago

quiet-node commented 7 months ago

Description:

Warning: This declaration shadows an existing declaration.
  --> contracts/solidity/scoping/Scoping.sol:21:13:
   |
21 |             uint x;
   |             ^^^^^^
Note: The shadowed declaration is here:
  --> contracts/solidity/scoping/Scoping.sol:18:9:
   |
18 |         uint x = 1;
   |         ^^^^^^

Warning: "selfdestruct" has been deprecated. The underlying opcode will eventually undergo breaking changes, and its use is not recommended.
  --> contracts/discrepancies/nonce/InternalCallee.sol:27:9:
   |
27 |         selfdestruct(_addr);
   |         ^^^^^^^^^^^^

Warning: "selfdestruct" has been deprecated. The underlying opcode will eventually undergo breaking changes, and its use is not recommended.
  --> contracts/discrepancies/nonce/InternalCaller.sol:56:9:
   |
56 |         selfdestruct(_addr);
   |         ^^^^^^^^^^^^

Warning: "selfdestruct" has been deprecated. The underlying opcode will eventually undergo breaking changes, and its use is not recommended.
  --> contracts/solidity/signature-example/ReceiverPays.sol:27:9:
   |
27 |         selfdestruct(payable(msg.sender));
   |         ^^^^^^^^^^^^

Related issue(s):

Fixes #435

Notes for reviewer:

Checklist

github-actions[bot] commented 7 months ago

Test Results

242 tests  ±0   236 :heavy_check_mark: ±0   7m 36s :stopwatch: -9s   72 suites ±0       6 :zzz: ±0    14 files   ±0       0 :x: ±0 

Results for commit 8568dc2a. ± Comparison against base commit 2eecfc6e.

:recycle: This comment has been updated with latest results.