Closed quiet-node closed 2 weeks ago
17 files + 3 86 suites +16 7m 54s :stopwatch: + 1m 18s 254 tests +19 246 :heavy_check_mark: +17 7 :zzz: +1 1 :x: +1 286 runs +51 275 :heavy_check_mark: +46 10 :zzz: +4 1 :x: +1
For more details on these failures, see this check.
Results for commit 18f09007. ± Comparison against base commit 024064d7.
:recycle: This comment has been updated with latest results.
overall looks good, leaved some nits and comments.
Also, I would like to see the test cases defined as:
- Grant Allowance (approve) from EOA to EOA
- Grant Allowance (approve) from EOA to Contract
- Grant Allowance (approve) from Contract to EOA
- Grant Allowance (approve) from Contract to Contract
- Get Current Allowance from owner account to another Account
- Get Current Allowance from owner account to an Smart Contract
I also think that the correct resolution of these scenarios will need for the EOA to call the system contract directly. due to Security model limitations.
Finally, not sure why are we adding this examples and tests as part of the HTS-Precompile folder, since is not related to HTS transfers but I would place it in its own folder called HAS-SystemContract (Hedera Account Service System Contract)
@AlfredoG87
Grant Allowance (approve) from EOA to EOA
Grant Allowance (approve) from EOA to Contract
Grant Allowance (approve) from Contract to EOA
Grant Allowance (approve) from Contract to Contract
Get Current Allowance from owner account to another Account
Get Current Allowance from owner account to an Smart Contract
Description:
walletAIHrc632 = new Contract(walletA.address, IHRC632, walletA)
;. This will make it possible for the EOA to directly make calls to the HAS precompile contracts, hence making the EOA top level caller of the transaction without any help from a third party like another SC account. That's when Hip-906 kicks in and allow hbar owner, top level caller, grant an hbar allowance to a spender.Related issue(s):
Fixes #797
Notes for reviewer:
Checklist