search

hashmesan / harmony-totp

SmartVault is a smart contract wallet designed with worry-free recovery using your Google Authenticator (no worry about secret, key phrases, device loss, email phishing, sms hijacking), and with many advanced wallet features.
https://sefwallet.one
21 stars 17 forks source link

App keeps on shutting down #67

Closed HB-Gwaay closed 2 years ago

HB-Gwaay commented 2 years ago

App shuts down on sending a token and adding a new custom token. It can not approve a transaction from a staking app as well.

hashmesan commented 2 years ago

Can you provide the token address you used , and the dapp you used? I'm seeing if it is token or app specific. Thanks!

HB-Gwaay commented 2 years ago

Hello there

The dapp I used is OneDAO and the token I tried to add is their native token ODAO. I am using IOS version Sef wallet. Sushiswap confirmation messages for transactions are also delaying a lot or not showing up at all.

On 8 Nov 2021 Mon at 20:47 hashmesan @.***> wrote:

Can you provide the token address you used , and the dapp you used? I'm seeing if it is token or app specific. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashmesan/harmony-totp/issues/67#issuecomment-963406808, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKWCH7Y7D4BLE65JYONU2LULAEJJANCNFSM5HTHUSIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

hashmesan commented 2 years ago

I found the issue with the crash... the filter screen crash due to no logo image. We'll default them to a blank image for until it gets listed. We'll bundle this fix in this week's release.

As for the approval tx:

I see the approve tx: https://explorer.harmony.one/tx/0x60b5986b6dcda38bd30159886d0814369141eeac409fdd73db1ffe13f93fedcd?activeTab=2 ; It was successful. Just try to reload the state, the app should see the previously approved tx.

Sushiswap state doesnt work quite right on farm pages, but for swap it seems to work fine. I'll report these findings to them. For now, you can close them a few seconds later, because the tx should be picked up. See this video: https://sefwallet.gitbook.io/sef-wallet/sef-+-sushi-liquidity-mine

HB-Gwaay commented 2 years ago

Thank you for your email

See the screenshot below, the moment I click that funnel the app shuts down automatically.

On 9 Nov 2021 Tue at 04:17 hashmesan @.***> wrote:

I found the issue with the crash... the filter screen crash due to no logo image. We'll default them to a blank image for until it gets listed. We'll bundle this fix in this week's release.

As for the approval tx:

I see the approve tx: https://explorer.harmony.one/tx/0x60b5986b6dcda38bd30159886d0814369141eeac409fdd73db1ffe13f93fedcd?activeTab=2 ; It was successful. Just try to reload the state, the app should see the previously approved tx.

Sushiswap state doesnt work quite right on farm pages, but for swap it seems to work fine. I'll report these findings to them. For now, you can close them a few seconds later, because the tx should be picked up. See this video: https://sefwallet.gitbook.io/sef-wallet/sef-+-sushi-liquidity-mine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashmesan/harmony-totp/issues/67#issuecomment-963723790, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKWCH6ENKHLQ3CNT5SRYP3ULBZBTANCNFSM5HTHUSIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

hashmesan commented 2 years ago

Correct, that "funnel" filter icon, is going to crash everytime until the new fix comes in. You can avoid it by delete the app & restore wallet... but adding custon token will still be broken until new fix :(

HB-Gwaay commented 2 years ago

Awesome, thanks!

On 9 Nov 2021 Tue at 05:00 hashmesan @.***> wrote:

Correct, that "funnel" filter icon, is going to crash everytime until the new fix comes in. You can avoid it by delete the app & restore... but adding custon token will still be broken until new fix :(

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashmesan/harmony-totp/issues/67#issuecomment-963743211, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKWCH4ZHZFN4OQ2V2LMR2DULB6EPANCNFSM5HTHUSIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

hashmesan commented 2 years ago

1.0.3 is available on appstore. You will need to remove the previous added token by toggle it off, then add it again. Sending also is fixed. (provided you re-add it again)

hashmesan commented 2 years ago

If this is still an issue, please reopen this.